prevent stuck scrollbar #2003
prevent stuck scrollbar #2003
Conversation
| and not event.button | ||
| and self._last_move_event is not None | ||
| ): | ||
| buttons = list(dict.fromkeys(self._down_buttons).keys()) |
There was a problem hiding this comment.
Isn't this the same as list(self._down_buttons)?
There was a problem hiding this comment.
Nope, it will additionally unique-ify them. Wether that is strictly necessary, I'm not certain.
There was a problem hiding this comment.
Ah, right. In that case, why not just buttons = set(self._down_buttons) and then iterate over the set?
Or do we need to preserve order?
It makes a bit more sense, it is probably faster, and doesn't require a comment explaining the hoops you are going over.
Otherwise, I think this warrants a comment.
Depending on what you reply to this comment, I don't mind PR'ing the change.
There was a problem hiding this comment.
It is intended to preserve order. So that any button ups, arrive in the same order as they went down. Feel free to add a comment.
Related comment: https://github.com/Textualize/textual/pull/2003\#discussion_r1131081129 Related PR: #2003.
Related comment: https://github.com/Textualize/textual/pull/2003\#discussion_r1131081129 Related PR: #2003.
Fixes the issue when you grab a scrollbar, move outside the terminal, and release the mouse button. The scrollbar would get attached to the mouse until you clicked the button again.
There was a previous attempt at this in #1968 but it didn't quite do the job.